Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more distinction between source and sink options when parsing CLI input #491

Open
caufieldjh opened this issue Apr 15, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@caufieldjh
Copy link
Collaborator

Describe the bug
get_source and get_sink in transformer.py (and possibly elsewhere) check the same value for format in the CLI.
This makes the assumption that all sources are also valid sinks and vice versa, which may not always be true, and may cause commands to fail if a name of a sink is not in the source map.
One solution - combine the source and sink map into something tracking source/sink status of all options.
Or, check both maps when parsing CLI input.

@caufieldjh caufieldjh added the bug Something isn't working label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant