Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KGX edge merge does not take into account enough attributes on the edge #413

Open
sierra-moxon opened this issue Oct 12, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@sierra-moxon
Copy link
Member

KGX currently tries to merge edges based on the following core properties:
{"id", "subject", "predicate", "object", "type"}

the knowledge_source properties should be added to the definition of unique, or we should have a parameter for KGX that allows the user to specify the merge parameters (like "no merge, I have my own unique identifier).

@sierra-moxon sierra-moxon added the bug Something isn't working label Oct 12, 2022
@sierra-moxon
Copy link
Member Author

https://github.com/biolink/kgx/blob/master/kgx/sink/neo_sink.py#L238 merges edges based on predicate not "key"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant