Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to walk up ontologies to find Biolink-Model mappings #378

Open
sierra-moxon opened this issue Mar 10, 2022 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@sierra-moxon
Copy link
Member

At the moment we have the ability to properly type some ontologies with their corresponding BM categories (e.g. MONDO classes get typed with biolink:Disease

if not category or category == "biolink:OntologyClass":
).

When a new ontology acts as a source, we often get very high level Biolink classes (biolink:NamedThing, etc.). One idea is to use the mappings in Bioportal to help KGX assign the correct Biolink Model category.

https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2815474/
https://data.bioontology.org/mappings?ontologies=SNOMEDCT,NCIT&display_context=false&display_links=false

@sierra-moxon sierra-moxon added the enhancement New feature or request label Mar 10, 2022
@goodb
Copy link

goodb commented May 20, 2022

This would be particularly useful when processing ontologies like the EFO that use a lot of OBO components but also mix in their own classes. e.g. right now, if you run EFO through the generic obo graph loader it mostly works but you end up with a bunch of nodes categorized as OntologyClass as you describe. For this ontology, you wouldn't need to use bioportal because it holds most (maybe all?) of the mappings needed as internal xrefs. e.g. EFO:0006505 'chronic bronchitis' is a child of 'disease' EFO:0000408 which has an xref to MONDO:0000001 .

Notably EFO, like many ontologies, doesn't maintain a precise mapping from namespace to upper semantic type so the current categorization method wouldn't work.

Leveraging the hard fought internal semantics and ontology mapping efforts to do a better job auto-categorizing kg nodes seems like a very good idea that would help expand the power of kgx as well as the overall value of the OBO effort.

@RichardBruskiewich
Copy link
Collaborator

Issue now related to #416?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants