Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotation assertion axioms (including subsets/slims) should by default be treated as node properties #358

Open
cmungall opened this issue Nov 15, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@cmungall
Copy link
Contributor

I am seeing e.g. in the chebi kgx that subsets like 3_STAR are being treated as nodes with inSubset as edges (type related_to)

edges should connect domain entities

for all annotation assertions (triples where the property is an AP) should be treated as node propeties

@justaddcoffee
Copy link

justaddcoffee commented Nov 15, 2021

Thanks Chris, a bit of context that might help the KGX dev team. Here is an example of the CHEBI KGX TSVs that Chris is referring to, containing these sorts of edges:

~ $ tar -xzvf chebi_kgx_tsv.tar.gz
x chebi_kgx_tsv_nodes.tsv
x chebi_kgx_tsv_edges.tsv
~ $ grep -i star chebi_kgx_tsv_edges.tsv | head
CHEBI:141943-biolink:related_to-OBO:chebi#2_STAR	CHEBI:141943	biolink:related_to	OBO:chebi#2_STAR		OIO:inSubset	tmpl2n2_ja9_chebi_relaxed.owl
CHEBI:65323-biolink:related_to-OBO:chebi#3_STAR	CHEBI:65323	biolink:related_to	OBO:chebi#3_STAR		OIO:inSubset	tmpl2n2_ja9_chebi_relaxed.owl
CHEBI:164715-biolink:related_to-OBO:chebi#2_STAR	CHEBI:164715	biolink:related_to	OBO:chebi#2_STAR		OIO:inSubset	tmpl2n2_ja9_chebi_relaxed.owl

This was generated in kg-obo with this code applied to (I think) this file

So you should be able to reproduce this with something like:

$ kgx --version
kgx, version 1.5.1
$ wget http://purl.obolibrary.org/obo/chebi.owl
$ kgx transform -i owl -f tsv chebi.owl

I think we'd like the object in these triples (OBO:chebi#2_STAR, OBO:chebi#3_STAR, etc) to be node properties instead of nodes themselves.

@sierra-moxon sierra-moxon added the bug Something isn't working label Mar 10, 2022
@sierra-moxon
Copy link
Member

@justaddcoffee - is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants