Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Domain: Converting to time fails on years < 1677 #6936

Open
ajdapretnar opened this issue Nov 21, 2024 · 1 comment
Open

Edit Domain: Converting to time fails on years < 1677 #6936

ajdapretnar opened this issue Nov 21, 2024 · 1 comment
Labels
bug report Bug is reported by user, not yet confirmed by the core team

Comments

@ajdapretnar
Copy link
Contributor

What's wrong?
I am working with historical data, with my timeseries representing years. I have two problems:

  1. When loading the data, the years are recognized as a Numeric column. Thus I have no option to define the format for datetime conversion. I'd like to specify these are years, not seconds.
  2. The years go before 1677. We perform the conversion with pd.to_datetime. For years before 1677, we would have to use pd.Period.

How can we reproduce the problem?
mfida.xlsx

  1. File (load mfida.xlsx).
  2. Edit Domain --> text.year to datetime. Observe the result in a Data Table.
  3. Now open File, convert text.year to text. Open Edit Domain, now you can select format, set it to 2021 (years).
  4. Inspect the data in a Data Table. Two years became missing values (1584, 1643).

What's your environment?

  • Operating system: OSX
  • Orange version: 3.38.0
  • How you installed Orange: .dmg
@ajdapretnar ajdapretnar added the bug report Bug is reported by user, not yet confirmed by the core team label Nov 21, 2024
@janezd
Copy link
Contributor

janezd commented Nov 22, 2024

Edit domain should show a warning that some values became undefined.

Edit domain should allow setting the date format for numeric variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug is reported by user, not yet confirmed by the core team
Projects
None yet
Development

No branches or pull requests

2 participants