Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Dask: Logistic Regression #6512

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

noahnovsak
Copy link
Contributor

@noahnovsak noahnovsak commented Jul 18, 2023

LogisticRegressionLearner and the corresponding widget now support DaskTables. Currently only for binary problems (*filtering rows doesn't work, because it doesn't update the target variable's list of possible values, to fix this we would need to check the contents the table instead).

Changes:

  • LogisticRegressionLearner imports dask_ml which we may not want to add to the requirements
  • _initialized_wrapped method of SklLearner now takes two arguments
  • DaskTable overrides _filter_has_class method to avoid using bottleneck on dask (assumes DaskTables are never sparse)
  • added np.asarray in a number of places to compute values when it seemed reasonable (statistics, predictions, test & score)

@noahnovsak noahnovsak changed the title dask compatible logistic regression Dask: Logistic Regression Jul 18, 2023
@markotoplak markotoplak added the dask Related (discovered in or needed) to the Dask adaptation label Jul 20, 2023
@noahnovsak noahnovsak force-pushed the dask-logisticregression branch 3 times, most recently from be51477 to ea6e31d Compare July 21, 2023 16:11
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #6512 (fd1a466) into dask (89e5caf) will decrease coverage by 0.01%.
The diff coverage is 81.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             dask    #6512      +/-   ##
==========================================
- Coverage   87.70%   87.70%   -0.01%     
==========================================
  Files         322      322              
  Lines       69981    70004      +23     
==========================================
+ Hits        61377    61395      +18     
- Misses       8604     8609       +5     

# Conflicts:
#	Orange/data/dask.py
@markotoplak markotoplak changed the title Dask: Logistic Regression [ENH] Dask: Logistic Regression Jul 26, 2023
@markotoplak markotoplak merged commit 1600af3 into biolab:dask Jul 26, 2023
15 of 22 checks passed
markotoplak added a commit to markotoplak/orange3 that referenced this pull request Jul 26, 2023
@noahnovsak noahnovsak deleted the dask-logisticregression branch July 26, 2023 09:30
markotoplak added a commit that referenced this pull request Aug 15, 2023
markotoplak added a commit that referenced this pull request Aug 17, 2023
markotoplak added a commit that referenced this pull request Aug 21, 2023
markotoplak added a commit that referenced this pull request Sep 4, 2023
markotoplak added a commit that referenced this pull request Sep 14, 2023
markotoplak added a commit to markotoplak/orange3 that referenced this pull request Sep 14, 2023
markotoplak added a commit that referenced this pull request Sep 18, 2023
markotoplak added a commit that referenced this pull request Sep 26, 2023
markotoplak added a commit that referenced this pull request Oct 10, 2023
markotoplak added a commit that referenced this pull request Oct 13, 2023
markotoplak added a commit that referenced this pull request Oct 21, 2023
markotoplak added a commit that referenced this pull request Oct 29, 2023
markotoplak added a commit that referenced this pull request Nov 6, 2023
markotoplak added a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask Related (discovered in or needed) to the Dask adaptation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants