Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include submitted query and provider in “result-selection-ready” event #673

Merged
merged 5 commits into from
Oct 14, 2023
Merged

Include submitted query and provider in “result-selection-ready” event #673

merged 5 commits into from
Oct 14, 2023

Conversation

tiberio-baptista
Copy link
Collaborator

@tiberio-baptista tiberio-baptista commented Oct 4, 2023 •
edited
Loading

This PR adds the submitted query and provider to the result-selection-ready event as a new request field.

This further enriched the data that result-batch web plugins have access to.

@tiberio-baptista tiberio-baptista changed the title Include submitted query in search servlet response Include submitted query in “result-selection-ready” event Oct 4, 2023
@tiberio-baptista tiberio-baptista changed the title Include submitted query in “result-selection-ready” event Include submitted query and provider in “result-selection-ready” event Oct 4, 2023
@bastiao bastiao self-requested a review October 14, 2023 20:21
bastiao
bastiao approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@bastiao bastiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with an use case plugin and it works fine.

@bastiao bastiao merged commit 46dc5d8 into bioinformatics-ua:dev Oct 14, 2023
3 checks passed
@bastiao bastiao deleted the imp/query-data-search-servlet branch October 14, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastiao bastiao bastiao approved these changes

@Enet4 Enet4 Awaiting requested review from Enet4

Assignees
No one assigned
Labels
enhancement webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiberio-baptista @bastiao @Enet4