Provide full search results on result-batch plugin mount event #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enet4
added
enhancement
webapp
breaking-change
webui-breaking-change
Enet4
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
The changes seem solid, and serve a good purpose. As the web UI plugin framework is not currently covered by semver stability guarantees, the upcoming version will be a patch release, 3.3.2. I will leave a warning in the release notes that the API for web UI result-batch plugins has changed.
I also filed an issue at generator-dicoogle-webplugin so that scaffolding webplugins consider this change in the future.
Enet4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webapp does not provide the full search results on the
result-selection-readyevent.This PR fixes this issue by providing both the search results and the search results that were selected via the UI, instead of only providing the selected entries.