Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch version 2.3.1 is converted to 2.3.1+cu121 automatically but CI doesn't use GPU #83

Closed
qin-yu opened this issue Jul 11, 2024 · 3 comments

Comments

@qin-yu
Copy link
Contributor

qin-yu commented Jul 11, 2024

  1. All of pytorch_version: 2.3.1, pytorch_version: 2.3.1+cpu, or pytorch_version: 2.3.1+cu121 will make installation of PyTorch fail, which is fixed by Fynn already.
  2. I think it complicates things if PyTorch version 2.3.1 is converted to 2.3.1+cu121 automatically by packaging when CI doesn't make use of GiHub Actions' GPU feature. Either of these should change.
bioimageio-core           0.6.7                    pypi_0    pypi
bioimageio-spec           0.5.3.post4              pypi_0    pypi
@FynnBe FynnBe transferred this issue from bioimage-io/core-bioimage-io-python Jul 11, 2024
@FynnBe
Copy link
Member

FynnBe commented Oct 14, 2024

Do the tests fail with those versions running in CI?
Have you tried adding the cpuonly package to the dependencies? (see https://pytorch.org/get-started/locally/)

@qin-yu
Copy link
Contributor Author

qin-yu commented Oct 14, 2024

The memories are vague. Maybe it doesn't cause failed tests. But I was saying for CIs the code should either use GPU packages on GPU-enabled CI machines, or use CPU-only packages on traditional CI machines.

@FynnBe
Copy link
Member

FynnBe commented Oct 14, 2024

For conda default environments in case only a pytorch version is given the cpuonly package is specified:

for model uploads that do specify a conda environment that may not be the case, but I'd rather not mess with those environments contributed by users as long as the CI passes.

closing for now. We'll visit this topic again when also running CI with GPUs eventually...

@FynnBe FynnBe closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants