Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bioimageio.core.test_model passes but GitHub CI fails #79

Closed
qin-yu opened this issue Jun 17, 2024 · 6 comments
Closed

bioimageio.core.test_model passes but GitHub CI fails #79

qin-yu opened this issue Jun 17, 2024 · 6 comments

Comments

@qin-yu
Copy link
Contributor

qin-yu commented Jun 17, 2024

Expected behaviour: if local test passes, then GitHub Actions should encounter no error.

My test:

image

GitHub Actions: https://github.com/bioimage-io/collection/actions/runs/9515502505/job/26230316192

@FynnBe
Copy link
Member

FynnBe commented Jul 5, 2024

The issue is that the conda environment that you have locally and that the CI is running with are not the same.
As discussed offline you can try to specify a different (higher) PyTorch version to have CI run in a more up-to-date environment where torch can be imported successfully (which is the issue in the current default pytorch env the CI installs for the pytorch version you specified).
Or, for pytorch state dict weights anyways, add a custom dependencies file. (I'd prefer the first option as your usecase should not require a custom conda env.

The ideal solution is to improve the default conda environment used in CI for the pytorch version that you specified (which would fix all models specifying that pytorch version 🎉 ).
This environment is determined here

@FynnBe FynnBe transferred this issue from bioimage-io/core-bioimage-io-python Jul 5, 2024
@qin-yu
Copy link
Contributor Author

qin-yu commented Jul 9, 2024

Thanks Fynn, I updated the env file for state dict and traced a CPU only torchscript. Not sure how to upload again.

@FynnBe
Copy link
Member

FynnBe commented Jul 10, 2024

just go to https://bioimage.io/#/ and click upload in the upper right corner:
https://bioimageio-uploader.netlify.app/#/uploader/add
(with id: philosophical-panda (in the RDF) to update your previous upload)

@FynnBe
Copy link
Member

FynnBe commented Jul 10, 2024

btw, I think I fixed all default pytorch envs.

@qin-yu
Copy link
Contributor Author

qin-yu commented Jul 11, 2024

For identical environments with identical packages, versions, and even build (except the build for libxml2), local CI passes while online version fails. See #84

@FynnBe
Copy link
Member

FynnBe commented Jul 15, 2024

closing in favor of #84

@FynnBe FynnBe closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants