Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note re: Slickgrid version #563

Open
fedarko opened this issue Aug 15, 2019 · 3 comments
Open

Note re: Slickgrid version #563

fedarko opened this issue Aug 15, 2019 · 3 comments

Comments

@fedarko
Copy link
Collaborator

fedarko commented Aug 15, 2019

While talking with @charles-cowart I realized that I wasn't actually sure which version of SlickGrid was in use (since the "main" SlickGrid repo stopped development almost 3.5 years ago).

After examining our slick.grid.js file, as well as this comment from Amanda, I'm pretty sure we're using the 6pac community fork (which is still actively maintained).

@charles-cowart suggested I make this issue in order to:

  1. just make note of this somewhere, because otherwise the next batch of LabControl developers will have to look this up
  2. make a note for the future about updating SlickGrid to the newest available version (it looks like the 6pac fork is on v2.4 and we're on v2.3, so if desired we can update to that as a part of this sprint).
@fedarko
Copy link
Collaborator Author

fedarko commented Aug 15, 2019

More notes for the future:

@fedarko
Copy link
Collaborator Author

fedarko commented Aug 16, 2019

Another note:

From what I can tell, we currently use an additional grid to simulate a "frozen column" (i.e. keeping the first column in place even when the plate is scrolled horizontally). This is documented in this comment.

It looks like (as of December 2018) SlickGrid officially supports frozen columns, so we could theoretically do away with this hack if we upgrade our SlickGrid version.

@charles-cowart
Copy link
Collaborator

I'd like to do away with the additional grid eventually; I will flag this for post full-release TODOs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants