Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Guidescan to v2.2.1 #50736

Closed
wants to merge 2 commits into from
Closed

Conversation

vineetbansal
Copy link
Contributor

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@vineetbansal
Copy link
Contributor Author

@BiocondaBot please update

@BiocondaBot
Copy link
Collaborator

I encountered an error updating your PR branch. You can report this to bioconda/core if you'd like.
-The Bot

@vineetbansal
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Sep 16, 2024
@standage
Copy link
Member

This was handled in #50738 thanks to the Bioconda bot.

@standage standage closed this Sep 16, 2024
@vineetbansal
Copy link
Contributor Author

vineetbansal commented Sep 16, 2024

@standage - thanks, but this PR also had a change to the meta.yml (addition of an additional-platforms section) that the corresponding PR #50738 by the bot didn't (and couldn't have) picked up. In these situations where there's a new release and a change in meta.yml, is there a recommended workflow to disable the bot so these confusions don't arise?

@standage
Copy link
Member

Hi @vineetbansal, sorry about that, I should have looked more closely.

When I need to make a change to meta.yml for my recipes, I typically wait for the bot to open the new PR automatically, then edit the file on that branch.

@vineetbansal
Copy link
Contributor Author

@standage - thanks. I'll keep that in mind going forward. For now, I've submitted another PR with this change (and the build number bumped). Hopefully that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants