Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSPACE identgroup date passed wrong date? #37

Open
jdeck88 opened this issue Feb 14, 2018 · 1 comment
Open

CSPACE identgroup date passed wrong date? #37

jdeck88 opened this issue Feb 14, 2018 · 1 comment

Comments

@jdeck88
Copy link
Member

jdeck88 commented Feb 14, 2018

In line 170 at https://github.com/biocodellc/biocode-fims-commons/blob/master/src/main/java/biocode/fims/query/writers/CspaceJsonWriter.java
t looks like we're creating an "identDateGroup" and passing in date,year,month,day as values but i think it should be identdate,identyear,identmonth,identday. This, however, should be happening in ALL cases, not just when det_date_display is blank or a non-parseable value. To: John Lowe: Can you verify this is true? I

@jblowe
Copy link

jblowe commented Feb 16, 2018

John,

I've looked at the code you suggest, and I concur that changing line 170 ought to do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants