Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discuss having a project level bcid for HASHed entites #32

Open
rodney757 opened this issue Feb 18, 2017 · 1 comment
Open

discuss having a project level bcid for HASHed entites #32

rodney757 opened this issue Feb 18, 2017 · 1 comment

Comments

@rodney757
Copy link
Contributor

rodney757 commented Feb 18, 2017

Currently when a project configuration entity contains HASH in the uniqueKey attribute, this means that the entity is to be treated as a value object.

To generate the suffix, we hash all the entity's attributes.

We are currently creating a bcid for every expedition in the project. However Value object bcids should probably only be created on the project level, and shared across all expeditions.

Ex.

A "Location" entity might have a "latitude" and a "longitude" Attributes. If 2 "Location" entities have the same attribute values, they are not unique instances, but are the same thing, thus they should have the same bcid.

We should also think about providing a flag on the Entity object to indicate that the entity is a value object, instead of relying on the Entity.uniqueKey() to end in HASH. Probably a bit more clear

@jdeck88
Copy link
Member

jdeck88 commented Feb 21, 2017

Yes, i would agree on providing a flag...
Also, for creating project level value-based roots.
Something tells me that we might actually bump this up to a "network"-based root. But that is another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants