Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] Try out Qulice; outcome, do not include Qulice in the project #490

Closed
jwlibby opened this issue May 22, 2024 · 1 comment
Closed
Labels
spike Explore options and questions

Comments

@jwlibby
Copy link
Collaborator

jwlibby commented May 22, 2024

Try out Qulice and see what you think. When evaluating refer to the questions in #462 and upon completion add your pros and cons for this plugin as a comment to the aforementioned story. Plugin link: Qulice

Note: Name is short for "quality police".

Book

Do mention and link to Qualice but mention drawbacks. And do not provide in the Gradle or Maven builds.

QA

As expected from previous experience, Qulice is very strict, and may not fit team agreements. Qulice is worth mentioning but with caution that teams adopt the strict standards. (An example: test methods should be marked final; this is true, but many teams may not want failures from this.)

See the "Use static analysis" page for writing update.

@jwlibby jwlibby added the spike Explore options and questions label May 22, 2024
@jwlibby jwlibby moved this to Backlog in @binkley's Modern Build May 22, 2024
@jwlibby jwlibby changed the title Try out qulice Try out Qulice May 22, 2024
@jwlibby jwlibby moved this from Backlog to Ready in @binkley's Modern Build May 22, 2024
@binkley binkley moved this from Ready to In progress in @binkley's Modern Build Jun 12, 2024
@binkley binkley self-assigned this Jun 12, 2024
@binkley
Copy link
Owner

binkley commented Jun 12, 2024

Out of the box, it changes PMD settings (correctly if very strictly), and complains about plain JUnit assert usage.
These cause multiple failures when the code base isn't following Qualice preferences.

@binkley binkley moved this from In progress to In review in @binkley's Modern Build Jun 12, 2024
@binkley binkley assigned jwlibby and unassigned binkley and jwlibby Jun 12, 2024
@binkley binkley moved this from In review to Done in @binkley's Modern Build Jun 19, 2024
@binkley binkley closed this as completed Jun 19, 2024
@binkley binkley changed the title Try out Qulice Try out Qulice; outcome, do not include Qulice in the project Jun 19, 2024
@binkley binkley changed the title Try out Qulice; outcome, do not include Qulice in the project [Spike] Try out Qulice; outcome, do not include Qulice in the project Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spike Explore options and questions
Projects
Status: Done
Development

No branches or pull requests

2 participants