-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spike] Try out Spotless; outcome: Do include Spotless in the project #489
Comments
|
spike can be found in spotless-spike branch |
Note: the |
@jwlibby The only feedback I have on the writing is this: * [Spotless](https://github.com/diffplug/spotless) — Focus on Google style guides for Java. I'm unsure what style to suggest here. For example, I noticed the Google style includes the "AOSP" variant that uses 4-space indentation rather than Google's odd 2-space indentation. Palantir is also an interesting choice. So perhaps soften the language to not offer a recommendation on style choice. |
Try out Spotless and see what you think. When evaluating refer to the questions in #462 and upon completion add your pros and cons for this plugin as a comment to the aforementioned story. Plugin link: Spotless.
Considerations for implementation cards:
lots of challenges, dependencies: Plexus, SLF4J, Kotlin, Eclipse; the plugin dependency wants Sonatype rather than Maven Centralalso easy. The challenges and dependencies issues mentioned were because I had incorrectly added the plugin as a dependency, not as a pluginRelated: #534 for epic on dependency management.
The text was updated successfully, but these errors were encountered: