Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[function- segment] [Why RGB2LAB & !BGR2LAB] #11

Open
ashishgupta1350 opened this issue Aug 4, 2018 · 2 comments
Open

[function- segment] [Why RGB2LAB & !BGR2LAB] #11

ashishgupta1350 opened this issue Aug 4, 2018 · 2 comments

Comments

@ashishgupta1350
Copy link
Contributor

Why did you segment image using RGB2LAB when you could have used BGR2LAB and set the threshold values on the third layer as 140-230. It gives the same result.

@antimatter15
Copy link
Collaborator

I believe the code that we're using is technically incorrect (since OpenCV uses BGR instead of RGB). We noticed this at some point and tried fixing it, but for some reason the correct implementation performed more poorly.

@ashishgupta1350
Copy link
Contributor Author

ashishgupta1350 commented Aug 6, 2018

Can you please send us the correct code? Let us see if we can debug and find errors in the correct code? I think we should be able to make a descent attempt at correcting it. We hope to scale the project across all platforms. It's done for the most part. I'll then design a GUI for calibrating the settings in real time and remove the need for installing dependencies on any pc.

Me and Ishika are computer science students working at you code as a hobby project. So far we have made sure your code works for windows and Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants