Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename customDataMapper to melodiiaDataMapper ? #55

Open
melicerte opened this issue Dec 3, 2019 · 1 comment
Open

Rename customDataMapper to melodiiaDataMapper ? #55

melicerte opened this issue Dec 3, 2019 · 1 comment
Milestone
v1.0.0

Comments

@melicerte
Copy link

customDataMapper seems too generic. What about using a more significant name ?
@Nek- Nek- added this to the v1.0.0 milestone Jan 3, 2020
@Nek-
Copy link
Contributor

Nek- commented Jan 3, 2020

Sounds reasonable, yes. Especially considering it may be an option Sf implements someday.

For insights, this is about the option name in the ApiType.

Please notice this should not be done before v1.0.0.

Nek- added a commit to Nek-/Melodiia that referenced this issue Dec 17, 2021
@Nek-
Merge pull request biig-io#55 from Nek-/feat/change-the-way-to-config…
7bd99e8 
…ure-the-documentation-controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@Nek- @melicerte