[RFC] Add to Melodiia a trait for form build

[Nek-]

Building forms is kinda repetitive but it is the recommended way to use Melodiia.

See what happens here, and here, and in any custom controller.

We could provide the following trait to make things smoother, here is an example of implementation:

use Symfony\Component\Form\FormFactoryInterface;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Zend\Json\Exception\RuntimeException;
use Zend\Json\Json;

trait GetFormHydratedWithJsonRequest
{
    private function getForm(Request $request, FormFactoryInterface $formFactory, string $type, $data = null): FormInterface
    {
        $form = $formFactory->createNamed('', $type, $data);
        try {
            $requestContent = Json::decode((string) $request->getContent(), Json::TYPE_ARRAY);
        } catch (RuntimeException $e) {
            throw new HttpException(Response::HTTP_BAD_REQUEST, 'Invalid input data', $e);
        }
        $form->submit($requestContent, Request::METHOD_PATCH !== $request->getMethod());

        return $form;
    }
}

[nimaamiri92]

Can explain more what you want?

[Nek-]

Hello @ARC92

Controllers provided by Melodiia have repetitive code. This is also the case of custom controllers. The goal of this issue is to provide a trait to avoid this repetitive code. In the thread I suggest directly an implementation.

What's new since this issue is that we have a trait. I'm not sure ATM that it should be inside the function the same trait. Probably. Here it is: https://github.com/biig-io/Melodiia/blob/master/src/Crud/Controller/CrudControllerTrait.php