From 1df7f4bccc2ff34af38a0fe2b8ec02619f8b048e Mon Sep 17 00:00:00 2001
From: Alexis Thinardon <alexis.thinardon@biig.fr>
Date: Fri, 21 Dec 2018 16:05:29 +0100
Subject: [PATCH] On type update throw an document not found error

---
 src/Exception/DocumentNotFoundException.php | 15 +++++
 src/Indexation/AbstractType.php             | 12 +++-
 tests/Indexation/AbstractTypeTest.php       | 65 +++++++++++++++++++++
 3 files changed, 91 insertions(+), 1 deletion(-)
 create mode 100644 src/Exception/DocumentNotFoundException.php
 create mode 100644 tests/Indexation/AbstractTypeTest.php

diff --git a/src/Exception/DocumentNotFoundException.php b/src/Exception/DocumentNotFoundException.php
new file mode 100644
index 0000000..32f523a
--- /dev/null
+++ b/src/Exception/DocumentNotFoundException.php
@@ -0,0 +1,15 @@
+<?php
+
+namespace Biig\Component\Elasticsearch\Exception;
+
+class DocumentNotFoundException extends \RuntimeException
+{
+    public function __construct(\Throwable $previous = null)
+    {
+        parent::__construct(
+            'Document not found',
+            0,
+            $previous
+        );
+    }
+}
diff --git a/src/Indexation/AbstractType.php b/src/Indexation/AbstractType.php
index 7711544..aa76e18 100644
--- a/src/Indexation/AbstractType.php
+++ b/src/Indexation/AbstractType.php
@@ -2,9 +2,11 @@
 
 namespace Biig\Component\Elasticsearch\Indexation;
 
+use Biig\Component\Elasticsearch\Exception\DocumentNotFoundException;
 use Biig\Component\Elasticsearch\Exception\NoElasticaTypeAvailable;
 use Biig\Component\Elasticsearch\Indexation\Doctrine\SimplePaginator;
 use Elastica\Document;
+use Elastica\Exception\ResponseException;
 use Elastica\Type;
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
@@ -54,7 +56,15 @@ public function update($object, $id)
             throw new NoElasticaTypeAvailable();
         }
 
-        $this->type->updateDocument(new Document($id, $object));
+        try {
+            $this->type->updateDocument(new Document($id, $object));
+        } catch (ResponseException $exception) {
+            if ('document_missing_exception' === $exception->getResponse()->getFullError()['type']) {
+                throw new DocumentNotFoundException($exception);
+            }
+
+            throw $exception;
+        }
     }
 
     public function stageForInsert(array $object, $id = null)
diff --git a/tests/Indexation/AbstractTypeTest.php b/tests/Indexation/AbstractTypeTest.php
new file mode 100644
index 0000000..5f91c11
--- /dev/null
+++ b/tests/Indexation/AbstractTypeTest.php
@@ -0,0 +1,65 @@
+<?php
+
+namespace Biig\Component\Elasticsearch\Test\Indexation;
+
+use Biig\Component\Elasticsearch\Indexation\AbstractIndex;
+use Biig\Component\Elasticsearch\Indexation\AbstractType;
+use Biig\Component\Elasticsearch\Indexation\Doctrine\SimplePaginator;
+use Biig\Component\Elasticsearch\Indexation\Hydrator\Hydrator;
+use Biig\Component\Elasticsearch\Indexation\Hydrator\HydratorFactory;
+use Biig\Component\Elasticsearch\Indexation\IndexInterface;
+use Biig\Component\Elasticsearch\Mapping\IndexBuilder;
+use Elastica\Client;
+use Elastica\Exception\ElasticsearchException;
+use Elastica\Exception\ResponseException;
+use Elastica\Index;
+use Elastica\Response;
+use Elastica\Type;
+use PHPUnit\Framework\TestCase;
+use Prophecy\Argument;
+use Psr\Log\LoggerInterface;
+
+class AbstractTypeTest extends TestCase
+{
+    /**
+     * @var LoggerInterface
+     */
+    private $logger;
+
+    public function setUp()
+    {
+        $this->logger = $this->prophesize(LoggerInterface::class);
+    }
+
+    /**
+     * @expectedException \Biig\Component\Elasticsearch\Exception\DocumentNotFoundException
+     */
+    public function testItAcceptTypes()
+    {
+        $type = $this->prophesize(Type::class);
+        $response = $this->prophesize(Response::class);
+        $exception = $this->prophesize(ResponseException::class);
+        $exception->getResponse()->willReturn($response->reveal());
+        $response->getFullError()->willReturn(['type' => 'document_missing_exception']);
+
+        $fooType = new FooType($this->logger->reveal());
+        $fooType->setType($type->reveal());
+
+        $type->updateDocument(Argument::any())->willThrow($exception->reveal());
+
+        $fooType->update(new \stdClass(), 'foo');
+    }
+
+}
+
+class FooType extends AbstractType
+{
+    public function getPaginator(): SimplePaginator
+    {
+    }
+
+    public function getName(): string
+    {
+        return 'bar';
+    }
+}