New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toward v3 #78

Open

Nek- opened this issue Sep 15, 2020 · 0 comments

Contributor

Nek- commented Sep 15, 2020 •

edited

Loading

Some issues are super interesting to fix here but require to break the compatibility. I suggest going on a v3 of the library.

https://github.com/biig-io/DomainComponent/pull/70/files
Dangerous usage of cacheableSupport in DomainDenormalizer #60 is also super-important
execute method should expect an interface #77 is probably a break as well

Also, v3 may remove any bc layer for Symfony 4 and ensure a clean code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment