New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execute method should expect an interface #77

Open

Nek- opened this issue Sep 15, 2020 · 0 comments

Contributor

Nek- commented Sep 15, 2020

Currently to have a good code in rules, we need to check if the event is an instance of the event we expect. (required at least by phpstan)

We could improve the situation by replacing DomainEvent by DomainEventInterface, because we can use children interface as type afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment