Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle landing zones of users with sufficient role removed from project #2043

Open
mikkonie opened this issue Dec 9, 2024 · 0 comments
Open
Assignees
Labels
app: landingzones Issue in the landingzones app feature Requested feature or enhancement tbd Comments wanted, spec/schedule/prioritization to be decided, etc.
Milestone

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Dec 9, 2024

It seems we have not fully considered some scenarios regarding landing zone management, where a user's roles are removed from a project. No one has reported this to me either.

Let's say a user creates a landing zone. Afterwards, the user's role in the project is removed or changed into project guest. This generates the following situation:

  • The landing zone still exists in iRODS
  • The user can access the landing zone and read/write files
  • The user lacks access to operations for validating, moving or deleting the landing zone
  • The project owner/delegate can see the zone and apply operations to it

This is confusing and should be clarified. My initial thoughts would be to append the procedure for changing/removing user roles as follows:

  • If a landing zone has no files, simply delete it
  • Else leave it and remove user read/write access to it, so that owner/delegate can handle cleanup
    • (OR, warn user removing the access and refuse changing of the perms (this is more complicated))
  • In the UI, denote that the user is no longer in the project or lacks sufficient permissions

I'm open for comments. Would the above be the best course of action, or should this be handled differently?

Once a plan is agreed upon, I can think of which modify API hooks the implementation needs to go, etc.

This is related to the following issues: #57, #1934, #1935.

@mikkonie mikkonie added feature Requested feature or enhancement tbd Comments wanted, spec/schedule/prioritization to be decided, etc. app: landingzones Issue in the landingzones app labels Dec 9, 2024
@mikkonie mikkonie added this to the v1.1.0 milestone Dec 9, 2024
@mikkonie mikkonie self-assigned this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: landingzones Issue in the landingzones app feature Requested feature or enhancement tbd Comments wanted, spec/schedule/prioritization to be decided, etc.
Projects
None yet
Development

No branches or pull requests

1 participant