Refactor AppSettingAPI.get_all() into get_all_by_scope(), deprecate

[mikkonie]

This method seems to be some kind of a remnant from a time long past. It's called get_all() but only returns app setting values with APP_SETTING_SCOPE_PROJECT.

In SODAR Core this is only used in tests, while in SODAR there is one use in taskflowbackend.plugins. I don't know about Varfish or Kiosc yet but will check.

I need to review its use and see if this should be removed completely, or refactored into something sensible. This may be a breaking change depending on which course I'll take.

Issues with the method:

• It says in the docstring it "returns all settings"
• In reality, it only gets definitions of APP_SETTING_SCOPE_PROJECT
• However, in parameters it allows setting user kwarg and no project

If filtering results to a specific scope are needed, this can be done by checking against definitions.

Spec

• Create get_all_by_scope() which works similarly, but explicitly requiring the scope
• Update usages
• Call get_all_by_scope() from get_all()
• Deprecate get_all() with a warning
• Document as breaking change

Tasks

• Do Allow scope=None in AppSettingAPI.get_definitions() #1535
• Create get_all_by_scope()
• Deprecate get_all()
• Update usages
• Update tests
• Document

[mikkonie]

Update: @stolpeo confirmed that this is used in Varfish. So we'll need to see about the usage there too.

[mikkonie]

Done.