Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoACMGClient Handles Slow Server Responses Improperly #825

Open
gromdimon opened this issue Sep 27, 2024 · 0 comments
Open

AutoACMGClient Handles Slow Server Responses Improperly #825

gromdimon opened this issue Sep 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@gromdimon
Copy link
Contributor

Describe the bug
The AutoACMGClient in our project consistently encounters a problem where server responses can take more then 5 seconds due to the complexity of the algorithm. However, the client does not always wait long enough for the response and occasionally returns a 204 No Content error prematurely or 500.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://reev.cubi.bihealth.org/seqvar/grch37-6-24302274-T-C?orig=GRCh37-6-24302274-T-C
  2. Open developer settings (network)
  3. Follow logs of auto-acmg on the server
  4. Encounter the problem

Expected behavior
The client should robustly handle long response times, waiting adequately until the server completes processing and returns the expected data. If the server is expected to take longer, the client should either retry or continue waiting rather than interpreting this as a 204 or 500 statuses.

Additional context

  • The issue may be exacerbated by network conditions or server load, but preliminary analysis suggests that it is primarily due to the client's handling of the HTTP response.
  • Consider investigating both the client timeout settings and the server's response time configurations to provide a comprehensive solution.
@gromdimon gromdimon added the bug Something isn't working label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant