Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associated Conditions Card sorts only presented data #513

Open
gromdimon opened this issue Feb 19, 2024 · 1 comment
Open

Associated Conditions Card sorts only presented data #513

gromdimon opened this issue Feb 19, 2024 · 1 comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code
Milestone
0.7.0

Comments

@gromdimon
Copy link
Contributor

Describe the bug
Currently Associated Conditions card provide functionality for sorting the PanelApps and Associated Diseases results. However, it sorts only the presented data and not the whole one.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://reev.cubi.bihealth.org/gene/BRCA1?genomeBuild=grch37#gene-conditions
  2. Try to sort Associated Conditions
  3. Encounter error

Expected behavior
Sorting should work on the whole data at one.

Additional context
Probably, we should change the current implementation of data-iterator to datatable.
@gromdimon gromdimon added the bug Something isn't working label Feb 19, 2024
@gromdimon gromdimon changed the title Associated Conditions Card sort only presented data Associated Conditions Card sorts only **presented** data Feb 19, 2024
@gromdimon gromdimon changed the title Associated Conditions Card sorts only **presented** data Associated Conditions Card sorts only presented data Feb 19, 2024
@gromdimon gromdimon self-assigned this Feb 21, 2024
@gromdimon gromdimon added this to the 0.7.0 milestone Feb 21, 2024
@gromdimon gromdimon added the javascript Pull requests that update Javascript code label Feb 21, 2024
@gromdimon gromdimon linked a pull request Mar 4, 2024 that will close this issue
chore: bump rfl fix asscociated conditions sorting (#513) #550
Closed
@gromdimon
Copy link
Contributor Author

In progress

@gromdimon gromdimon removed their assignment Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working javascript Pull requests that update Javascript code
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

chore: bump rfl fix asscociated conditions sorting (#513) bihealth/reev
1 participant
@gromdimon