Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Error Logging Inconsistencies in MdTag.scala #2401

Open
joonkang-git opened this issue Aug 2, 2024 · 0 comments
Open

Refactoring Error Logging Inconsistencies in MdTag.scala #2401

joonkang-git opened this issue Aug 2, 2024 · 0 comments
Milestone

Comments

@joonkang-git
Copy link

After review there were several inconsistencies found in the file MdTag.scala in terms of error logging.

throw new IllegalArgumentException(s"MdTag $mdTagInput does not start with a digit")

case _ => throw new IllegalStateException("Could not find deleted base at cigar offset " + i)

These are included in the code without a clear pattern to their usage. In addition the error messages associated are inconsistent in detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants