Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://developer.bigcommerce.com/docs/rest-authentication/tokens#create-a-token bad example request #377

Closed
pcfco-kmason opened this issue Jul 16, 2024 · 1 comment

Comments

@pcfco-kmason
Copy link

pcfco-kmason commented Jul 16, 2024

What is the link to the page that needs updating? Provide multiple links if needed.

example has trailing slash in allowed_cors_origins

What needs to be documented?

remove the trailing slash in the example for allowed_cors_origins:

{
"allowed_cors_origins": [
"https://www.yourstorefront.com"
],
"channel_id": 1,
"expires_at": 1885635176
}
response when using example:
{
"status": 422,
"title": "The following fields are invalid: allowed_cors_origins:has_invalid_suffix",
"type": "https://developer.bigcommerce.com/api-docs/getting-started/api-status-codes",
"errors": {
"allowed_cors_origins:has_invalid_suffix": "A supplied origin has a trailing slash or other special character following the end of the domain. Please remove any trailing characters in supplied origins."
}
}

What is currently documented?

{
"allowed_cors_origins": [
"https://www.yourstorefront.com/"
],
"channel_id": 1,
"expires_at": 1885635176
}

@bc-traciporter
Copy link
Collaborator

Thank you @pcfco-kmason . We are fixing this now in PR 501.

bc-traciporter added a commit that referenced this issue Sep 6, 2024
<!-- Ticket number or summary of work -->
# [Issue-377](#377)


## What changed?
Removed trailing slash from example


## Release notes draft

N/A - Bug Fix

## Anything else?
<!-- Add related PRs, salient notes, additional ticket numbers, etc. -->

ping {names}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants