Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected addition of characters to AP names under 5 characters #52

Open
SegerEnd opened this issue Jul 29, 2023 · 0 comments · May be fixed by #54
Open

Unexpected addition of characters to AP names under 5 characters #52

SegerEnd opened this issue Jul 29, 2023 · 0 comments · May be fixed by #54

Comments

@SegerEnd
Copy link

When attempting to set an AP name with less than 5 characters, it unexpectedly adds extra characters to the provided name.

Steps to Reproduce:

  1. Attempt to set an AP name with fewer than 5 characters, e.g., "ABC" or "HI"
  2. See inside the Serial that the resulting AP name has the extra characters. "ABCTAL", "HIRTAL".

Expected Behavior:
When setting an AP name with less than 5 characters, it should retain the provided name as is, without adding any extra characters. So, "HEY" should remain "HEY".

Actual Behavior:
Additional characters are added to the AP names with fewer than 5 characters, resulting in unexpected names. For instance, if "HEY" is set as the AP name, it becomes "HEYTAL," and if i set "A" is set, it becomes "AORTAL."

When I changed the code within evil_portal_storage.c to use an empty string for the AP name app->ap_name = (uint8_t *)""; the name becomes "PORTAL," indicating that the characters are being layered on top of the "PORTAL" string.

@manu0466 manu0466 linked a pull request Jul 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant