Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger logger.error level log if unable to load specific plugin #22746

Open
antobinary opened this issue Mar 20, 2025 · 3 comments
Open

Trigger logger.error level log if unable to load specific plugin #22746

antobinary opened this issue Mar 20, 2025 · 3 comments

Comments

@antobinary
Copy link
Member

Describe the bug
On the client we have several logs for the plugin loading process.

  • "Loaded plugin PickRandomUserPlugin"
  • "2/2 plugins loaded"

However, in the case of not being able to load a plugin (bad url or version incompatibility), we need to log (error level)
the name of the plugin, the error, a logCode so these could be spotted.

@GuiLeme
Copy link
Collaborator

GuiLeme commented Mar 21, 2025

In case of bad URL, this is already done, see:

Image

It seems we already have the 'plugin_load_error' logCode for that.

Now, as for the version compatibility, we still need to add a blocker to not load versions that are not compatible (SDK match). IMO, this would need to be done in akka, so the initial idea I had was to have the SDK version duplicated into settings.yml, this would be read by akka and it could block plugin manifests that requires different versions that what the client has.

Of course that's open for discussion, but that's my initial ideia of how to do that.

And on the logging discussion, this error log would be located in akka.

@antobinary
Copy link
Member Author

Thanks! Sounds great! Would you prefer we close now or when you're done the SDK version portion?

@GuiLeme
Copy link
Collaborator

GuiLeme commented Mar 21, 2025

Let it open for now, I'll close it with a PR, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants