Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements. #1

Open
5 tasks
ypriverol opened this issue Nov 28, 2021 · 0 comments
Open
5 tasks

Performance improvements. #1

ypriverol opened this issue Nov 28, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@ypriverol
Copy link
Member

ypriverol commented Nov 28, 2021

Currently, msgf+ is used in combination with Comet by quantms pipeline for searching. However, in cloud infrastructure, it is desirable that the search engine runs faster and consume less memory resources. Any improvement we can make to the current version will impact quantms.

Some ideas from exiting search engines we can explore:

  • (MOST Important)The fragment index store system implemented by MSFragger and other search engines. Here, you can see a nice explanation about the idea: https://www.nature.com/articles/s41467-019-11337-z.
  • Related with the previous comment. When msgf+ index the fasta database for searching, do not included the ptms added to the search (Comet strategy) (see comment How to reduce MS-GF+ search time MSGFPlus/msgfplus#108 (comment))
  • mzML loading: MSGF+ uses for reading the mzML files the library jmzReader. However, a new version of that library with faster reading implementation can be found here: https://github.com/bigbio/pgatk-io. Please benchmark before replacing the libraries.
  • Other minor improvements can be about use more efficient java 8/9/11 features.

Other possible improvements:

@ypriverol ypriverol added the enhancement New feature or request label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant