Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement responsive Menu using three dot menu approach #1112

Closed
Tracked by #1100
praveen-murali-ind opened this issue May 28, 2024 · 1 comment · Fixed by #1118
Closed
Tracked by #1100

Implement responsive Menu using three dot menu approach #1112

praveen-murali-ind opened this issue May 28, 2024 · 1 comment · Fixed by #1118
Assignees
Labels
1.75D Estimate - 14 hours PR The issue has a PR associated with it.

Comments

@praveen-murali-ind
Copy link
Contributor

@deepakjosp _a As discussed, please start working on this once #1111 is merged.

cc @AbhayVAshokan

Ref - #1100 (comment)

GitHub Ref

Screen.Recording.2024-05-28.at.3.04.13.PM.mov
@praveen-murali-ind praveen-murali-ind changed the title Implement responsive Edit Menu using three dot menu approach Implement responsive Menu using three dot menu approach May 28, 2024
@deepakjosp deepakjosp mentioned this issue May 28, 2024
20 tasks
@deepakjosp deepakjosp added 0.75D Estimate - 6 hours 1.25D Estimate - 10 hours and removed 0.75D Estimate - 6 hours labels May 29, 2024
@neetogit-bot neetogit-bot bot added working A branch associated with this issue is created. PR The issue has a PR associated with it. labels May 29, 2024
@deepakjosp deepakjosp linked a pull request May 30, 2024 that will close this issue
4 tasks
@deepakjosp
Copy link
Contributor

@AbhayVAshokan the estimate for this went beyond the plan because:

  1. I had to entirely refactor the way the fixed menu was rendered.
  2. Few of the helpers and component which were used in fixed menu was re-used by bubble menu. I had to fix those because I made changes to the utils and bubble menu was not compatible.

Updating the ETA to 1.75D _t

@neetogit-bot neetogit-bot bot added the 1.75D Estimate - 14 hours label May 31, 2024
@deepakjosp deepakjosp removed the 1.25D Estimate - 10 hours label May 31, 2024
@neetogit-bot neetogit-bot bot removed the working A branch associated with this issue is created. label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.75D Estimate - 14 hours PR The issue has a PR associated with it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants