Invalid filters are ignored / not parameterizable

[adelavega]

See: bids-standard#863 (comment)

[adelavega]

bids-standard#596

I suggest we don't allow invalid filters in the future, and force error

[erdalkaraca]

there is also a related bug in ancpbids repo:
ANCPLabOldenburg/ancp-bids#58

[adelavega]

In pybids we currently have invalid_filters which allows you to set the behavior. This was done for backwards compatability, as by default it throws an error, but it'll allow you to set invalid_filters='ignore' to replicate old behavior.

I think we can probably get rid of it soon.

[adelavega]

Currently, ancpbids is equivalent to ignore_filters='allow', such that if you pass an invalid filter, it will return no results. It is more helpful to raise an error, but requires knowing all valid keys (possibly including meta-data). "drop" drops the invalid key and performs the query.

I suggest we start by trying to implement ignore_filters='raise in ancpbids, to see if its possible without major peformance issues.