Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #98

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fix bugs #98

wants to merge 14 commits into from

Conversation

julia-pfarr
Copy link
Member

closes #96

julia-pfarr and others added 13 commits June 20, 2024 16:58
edf2asc suddenly gives out a random order for the calibration positions. E.g., calibration point 3 is listed after calibration point 4. That's why I had to change the function _extract_Calibration poisition (as well as _get_calibration_positions). However, now the tests are failing because something is wrong with the lists in lists thingi and also it tries to get the calibration positions also for the testfiles which have none. I thought I specified that within the functions but obviously it doesn't work.
…because otherwise it writes wrong content into the variable
@julia-pfarr
Copy link
Member Author

some tests are failing but they're also failing on the main branch and are unrelated to these changes. We need to fix them

@Remi-Gau
Copy link
Contributor

Remi-Gau commented Sep 5, 2024

the failing tests are due to #69: let me flag them as expected failure to avoid confusion

Copy link
Contributor

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a test to ensure that the generated output is a single number?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eye2bids classifying StartTime and StopTime metadata as arrays rather than numbers [BUG]
2 participants