Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickup config from a dataset at some standard location #741

Closed
yarikoptic opened this issue Mar 6, 2019 · 5 comments · Fixed by #891
Closed

Pickup config from a dataset at some standard location #741

yarikoptic opened this issue Mar 6, 2019 · 5 comments · Fixed by #891
Assignees

Comments

@yarikoptic
Copy link
Contributor

ATM config should be specified in the command line. Since config quite often dataset specific, such configuration would be stored within the dataset. To not breed various user-specific paths, would be nice to standardize location of such a config (e.g. .bids-validator.cfg) and pick it up by default. It would then require an option to avoid loading it though (e.g. an empty config path in -c?)

Might interact with #279

@yarikoptic
Copy link
Contributor Author

ha ha - was looking for something like that and found that me-in-the-past already expressed himself. I wish I knew JS enough to not break things, then I would have submitted a PR ;-)

@yarikoptic
Copy link
Contributor Author

I found myself again here! amazing! So is there a perspective to have this issue addressed (or at least commented on), or I will just keep talking to the past myself here? ;)

@effigies
Copy link
Collaborator

This is definitely beyond my JS knowledge, so I don't even have a sense of how great an effort this would be.

@62442katieb Do you happen to have some time to prod at this?

@yarikoptic Do you know any JS developers?

@nellh
Copy link
Member

nellh commented Dec 18, 2019

I've added a quick version of this in #891 - documentation for how it works is here. This does introduce a breaking change since relative configuration paths are now interpreted as dataset relative.

@yarikoptic
Copy link
Contributor Author

THANK YOU @nellh -- skimmed through the code (I have little to no JS knowledge, so it was very superficial) -- looks great to me ;) FWIW, in the use case where I was providing config file, I was using absolute path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants