-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deno: could --schema be made to take src/schema
yaml tree as input?
#1946
Comments
We did write the Python tooling to do the dereferencing once and spit out the result, to avoid having to implement it consistently. You're welcome to reimplement it, but we should add tests that ensure that the Javascript implementation doesn't diverge from the Python one. |
if it is not implemented, I guess fine with me. I just saw bids-validator/src/setup/loadSchema.test.ts:Deno.test('schema yaml loader', async (t) => { and assumed that it was but may be just not interfaced. If you confirm that the machinery is not actually here or should not be used -- we can just forget that I asked ;) |
I did write a direct yaml loader at first but it couldn't load the current schema or do all of the dereferencing required, that would all need to be implemented still. |
ok, let's then consider it not there and not needed for now ;-) |
Somewhat a continuation to #1930 . For development purposes it would be easier if I could just point to
src/schema
of the bids-specification instead of requiring to "compile"schema.org
using python tooling. I thought I even saw within bids-validator functionality to load schema from yamls but I could be wrong. My attempt though didn't work out:❯ bids-validator-deno ds000246/ --schema file:///home/yoh/proj/bids/bids-specification-master/src/schema TypeError: Is a directory (os error 21) at async loadSchema (file:///home/yoh/proj/bids/bids-validator/bids-validator/src/setup/loadSchema.ts:21:26) at async validate (file:///home/yoh/proj/bids/bids-validator/bids-validator/src/validators/bids.ts:37:18) at async main (file:///home/yoh/proj/bids/bids-validator/bids-validator/src/main.ts:16:24) at async file:///home/yoh/proj/bids/bids-validator/bids-validator/src/bids-validator.ts:3:1 { code: "ERR_MODULE_NOT_FOUND" } Warning, could not load schema from file:///home/yoh/proj/bids/bids-specification-master/src/schema, falling back to internal version ...
although works for the .json:
❯ bids-validator-deno ds000246/ --schema file:///home/yoh/proj/bids/bids-specification-master/src/schema.json [WARNING] Task scans should have a corresponding 'events.tsv' file. ...
but only using that `-deno` executor on top of `.ts` and not direct one over the "compiled" JS version -- which is the https://github.com//issues/1943
The text was updated successfully, but these errors were encountered: