Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT cannot be transferred back to the original chain if ClassId contains the IBC separator #14

Closed
taramakage opened this issue Apr 11, 2023 · 0 comments

Comments

@taramakage
Copy link
Contributor

taramakage commented Apr 11, 2023

As pointed out by @giansalex in gon-evidence#245, an NFT under a Class with a ClassId that contains the IBC separator / cannot be transferred back to its original chain.

This is because types.ParseClassTrace() assumes that there is no slash in the base ClassId. As a result, it processes p/0/1 as the path p/0 and the base ClassId 1.

To address this issue, we could:

  1. either modify the spec and separate the ClassId field into ClassTrace and BaseClassId fields, and distinguish them without relying on a single slash.
  2. or restrict the use of slashes in ClassId.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant