ŇḞÇ ňöŗṁàḷīʑéɖ ƫë×Ɨ ʍʴɑᴾƿïŋğ #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Picture of the wrapping in action...
|
bhutch29
approved these changes
Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFC normalized text wrapping, for drink names that are too long. This should close #106 when merged.
Currently it can support name lengths of up to 60 characters, regardless of character set or diacritics, macrons, etc. It seems to work with most of the major language blocks, but it doesn't work with glitch text. I think this may be due to poor unicode support in either Windows command prompt or the font I've chosen, and not necessarily a bug on our side of things.
In the future we should think of a more robust solution that allows for arbitrary lengths of text, but for now we are limited to 60 characters which seems sufficient.