Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on "429 Too Many Requests" [Request] #1

Open
apaatsio opened this issue Jul 5, 2016 · 2 comments
Open

Retry on "429 Too Many Requests" [Request] #1

apaatsio opened this issue Jul 5, 2016 · 2 comments

Comments

@apaatsio
Copy link

apaatsio commented Jul 5, 2016

It would be convenient to automatically re-add the request to the queue if server returns 429 Too Many Requests error. This should be configurable so we can set the maximum number of retries.

This is for situations where the network is not optimal (e.g. bad network can cause bursts and the rate limit to exceed at the server). Another situation is when you have two clients using the same API at the same time. If both clients are sending requests at the maximum rate, the total will be 2x rate limit and a lot of 429s.

@bhollis
Copy link
Owner

bhollis commented Jul 6, 2016

That'd be cool! Would you want to take a crack at submitting a PR for that?

On Tuesday, July 5, 2016, Antti Ahti [email protected] wrote:

It would be convenient to automatically re-add the request to the queue if
server returns 429 Too Many Requests error. This should be configurable so
we can set the maximum number of retries.

This is for situations where the network is not optimal (e.g. bad network
can cause bursts and the rate limit to exceed at the server). Another
situation is when you have two clients using the same API at the same time.
If both clients are sending requests at the maximum rate, the total will be
2x rate limit and a lot of 429s.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1, or mute the
thread
https://github.com/notifications/unsubscribe/AATHeFzwS4z8MnROOLN1E-yGRhqFPVaWks5qShZfgaJpZM4JE4wj
.

@apaatsio
Copy link
Author

apaatsio commented Jul 6, 2016

I might have time next week for that. Let's see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants