Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output of callingWaterfall.R#L54 #183

Open
bhaibeka opened this issue Mar 24, 2024 · 2 comments
Open

Improve output of callingWaterfall.R#L54 #183

bhaibeka opened this issue Mar 24, 2024 · 2 comments
Assignees

Comments

@bhaibeka
Copy link
Member

Add an output and/or a message to inform the user that the linear approximation has been used. I would also store all the parameters used to call to categorize cell lines based on their drug response data (ie, type, intermediate.fold , and cor.min.linear)

@jjjermiah jjjermiah self-assigned this Mar 25, 2024
@jjjermiah
Copy link
Contributor

context:

The cor.min.linear argument appears to be the minimum Pearson correlation coefficient between the linear distribution model and actual drug response values, such that the waterfall distribution can be called linear triggering the alternate method for determining two sensitivity groups. Is this correct?

Following this, in the output, will it be obvious which of the two methods was used to great two groups?

Additionally, it may also be useful to know if we should be using the defaults for the cor.min.linear and intermediate.fold arguments.

  1. Add output message of which method has been used

Relevant code:

https://github.com/bhklab/CoreGx/blob/bf6d814abd3dc0fc98f9f419f430cc6473046cb2/R/callingWaterfall.R#L104C5-L122C6

  1. Store parameters used in function
  • type
  • intermediate.fold
  • cor.min.linear

Do we want to return these to the user (named list) or output as a message (or both?)

@jjjermiah
Copy link
Contributor

@bhaibeka

  1. added info messages if logging options set to verbose
  2. return the parameters and cutoff information as attributes

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants