Skip to content

improve bevy_ui Direction docs #8314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adsick opened this issue Apr 6, 2023 · 3 comments
Closed

improve bevy_ui Direction docs #8314

adsick opened this issue Apr 6, 2023 · 3 comments
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Docs An addition or correction to our documentation

Comments

@adsick
Copy link
Contributor

adsick commented Apr 6, 2023

not a big deal, but the doc comments are talking about text direction, while Style.direction is about content direction.
image

@adsick adsick added C-Docs An addition or correction to our documentation S-Needs-Triage This issue needs to be labelled labels Apr 6, 2023
@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets and removed S-Needs-Triage This issue needs to be labelled labels Apr 6, 2023
@nicoburns
Copy link
Contributor

I don't think bevy actually implements the content direction part of the direction property.

In my CSS Grid PR I have updated the descriptions all the style props and have written the following about direction:

/// Defines the text direction. For example English is written LTR (left-to-right) while Arabic is written RTL (right-to-left).
///
/// Note: the corresponding CSS property also affects box layout order, but this isn't yet implemented in bevy.
/// <https://developer.mozilla.org/en-US/docs/Web/CSS/direction>

@ickshonpe
Copy link
Contributor

I made an example for direction ages ago, I'll make a PR it for after the game jam is over.

@doup
Copy link
Contributor

doup commented Oct 16, 2024

I think this one can be closed since direction was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Docs An addition or correction to our documentation
Projects
None yet
Development

No branches or pull requests

5 participants