Skip to content

Give dynamic feature a more explicit name like dynamic_linking? #7334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alice-i-cecile opened this issue Jan 22, 2023 · 1 comment
Closed

Give dynamic feature a more explicit name like dynamic_linking? #7334

alice-i-cecile opened this issue Jan 22, 2023 · 1 comment
Labels
A-Meta About the project itself C-Code-Quality A section of code that is hard to understand or change C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide

Comments

@alice-i-cecile
Copy link
Member 

          Could you give the feature a more explicit name like `dynamic_linking`?

Originally posted by @mockersf in #7333 (review)
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change A-Meta About the project itself M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Jan 22, 2023
@Nilirad
Copy link
Contributor

Nilirad commented Jan 22, 2023

The culprit here was bevy_dynamic_plugin's name being confused for the dynamic linking feature. I agree though that dynamic_linking is better than dynamic.

@lewiszlw lewiszlw mentioned this issue Jan 23, 2023
Closed
@bors bors bot closed this as completed in 0297805 Jan 23, 2023
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@lewiszlw @ItsDoot
Rename dynamic feature (bevyengine#7340)
8efea1b 
# Objective

- Fixes bevyengine#7334

## Solution

- Rename `dynamic` feature to `dynamic_linking`.

---

## Migration Guide
- `dynamic` feature was renamed to `dynamic_linking`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Meta About the project itself C-Code-Quality A section of code that is hard to understand or change C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Rename dynamic feature
2 participants
@alice-i-cecile @Nilirad