Skip to content

Improve documentation for enum reflection #6985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrGVSV opened this issue Dec 19, 2022 · 1 comment
Closed

Improve documentation for enum reflection #6985

MrGVSV opened this issue Dec 19, 2022 · 1 comment
Labels
A-Reflection Runtime information about types C-Docs An addition or correction to our documentation

Comments

@MrGVSV
Copy link
Member

MrGVSV commented Dec 19, 2022

How can Bevy's documentation be improved?

Enums require all variant fields to implement FromReflect in order to implement Reflect themselves (this is due to a similar limitation as Vec<T> in the Reflect::apply method implementation).

This behavior should either be documented on Reflect or at least on Enum.

@MrGVSV MrGVSV added C-Docs An addition or correction to our documentation S-Needs-Triage This issue needs to be labelled labels Dec 19, 2022
@alice-i-cecile alice-i-cecile added A-Reflection Runtime information about types and removed S-Needs-Triage This issue needs to be labelled labels Dec 19, 2022
@MrGVSV MrGVSV added this to Reflection Jan 1, 2023
@MrGVSV
Copy link
Member Author

MrGVSV commented Feb 20, 2023

This should be covered by #7148

@MrGVSV MrGVSV closed this as completed Feb 20, 2023
@github-project-automation github-project-automation bot moved this from Open to Done in Reflection Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reflection Runtime information about types C-Docs An addition or correction to our documentation
Projects
Status: Done
Development

No branches or pull requests

2 participants