Skip to content

running examples in CI got a lot slower since using the new renderer #3344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mockersf opened this issue Dec 15, 2021 · 2 comments
Closed

running examples in CI got a lot slower since using the new renderer #3344

mockersf opened this issue Dec 15, 2021 · 2 comments
Labels
A-Build-System Related to build systems or continuous integration C-Performance A change motivated by improving speed, memory usage or compile times

Comments

@mockersf
Copy link
Member

Bevy version

Latest from main add1818a05ad4b8d4672197afd477ab29f8446b5

Operating system & version

Ubuntu from GitHub actions

What you did

Run CI

What you expected to happen

Examples run in an acceptable time (1 mins to build, 8 mins to run)

What actually happened

As noted by @cart in #3312 (comment), it takes more time to run examples: 1 mins to build, 33 mins to run

Additional information

Before the merge: https://github.com/bevyengine/bevy/runs/4499607967?check_suite_focus=true
After the merge: https://github.com/bevyengine/bevy/runs/4532054231?check_suite_focus=true

run-examples CI should be made faster, or it should run less examples. Ideally it's run time should be around 10 minutes total
@mockersf mockersf added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled A-Build-System Related to build systems or continuous integration and removed C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Dec 15, 2021
@alice-i-cecile alice-i-cecile added the C-Performance A change motivated by improving speed, memory usage or compile times label Dec 15, 2021
@alice-i-cecile
Copy link
Member

Can we limit running some of the examples based on which code was modified?

@mockersf
Copy link
Member Author

mockersf commented Dec 16, 2021 •
edited
Loading

I captured a trace in CI: trace-1639616852.json.zip, you can view it in https://ui.perfetto.dev.

It seems the culprit is present_frames: It's taking around 600ms each frame, so everything is running at less than 0.5 fps...

@mockersf mockersf mentioned this issue Dec 17, 2021
Closed
bors bot pushed a commit that referenced this issue Dec 17, 2021
@mockersf
CI: use lavapipe instead of swiftshader when running examples (#3358)
2217afb 
# Objective

- fixes #3344
- have example run faster

## Solution

- thanks to the nice folks at wgpu, I was able to switch from swift shader to lavapipe which is faster
- I also reduced the runtime for some of the examples
- I enabled the trace_chrome feature on the examples, and stored the results as an artefact. it can be useful to debug
- runtime is back to around 10 minutes


Co-authored-by: François <[email protected]>
@bors bors bot closed this as completed in e677755 Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Performance A change motivated by improving speed, memory usage or compile times
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - CI: use lavapipe instead of swiftshader when running examples mockersf/bevy
2 participants
@alice-i-cecile @mockersf