Skip to content

Transparent things don't render and cause warning spam #17846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rparrett opened this issue Feb 13, 2025 · 1 comment · Fixed by #17849
Closed

Transparent things don't render and cause warning spam #17846

rparrett opened this issue Feb 13, 2025 · 1 comment · Fixed by #17849
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior

Comments

@rparrett
Copy link
Contributor

rparrett commented Feb 13, 2025 •
edited
Loading

Bevy version

main, bisected to #17764

Relevant system information

SystemInfo { os: "macOS 15.3 Sequoia", kernel: "24.3.0", cpu: "Apple M4 Max", core_count: "16", memory: "64.0 GiB" }    
AdapterInfo { name: "Apple M4 Max", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }

But this also reproduces on linux and mac CI in the example report.

What you did

cargo run --example blend_modes

What went wrong

Only the leftmost opaque sphere is drawn.

WARN bevy_pbr::render::mesh: Not rendering mesh because indexed indirect parameters buffer wasn't present
Image

Additional information

This affects many other examples.

See https://pixel-eagle.com/project/b25a040a-a980-4602-b90c-d480ab84076d/run/8274/compare/8263?screenshot=3D%20Rendering/transparency_3d.png
@rparrett rparrett added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Feb 13, 2025
pcwalton added a commit to pcwalton/bevy that referenced this issue Feb 13, 2025
@pcwalton
Actually add objects to the scene buffers in sorted render phases.
3ba1353 
There was nonsense code in `batch_and_prepare_sorted_render_phase` that
created temporary buffers to add objects to instead of using the correct
ones. I think this was debug code. This commit removes that code in
favor of writing to the actual buffers.

Closes bevyengine#17846.
@pcwalton pcwalton mentioned this issue Feb 13, 2025
Merged
@pcwalton
Copy link
Contributor

Oops, sorry about this! #17849 should be a fix.

@ickshonpe ickshonpe added S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Feb 13, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 14, 2025
@pcwalton @alice-i-cecile
Actually add objects to the scene buffers in sorted render phases. (#…
3c9e696 
…17849)

There was nonsense code in `batch_and_prepare_sorted_render_phase` that
created temporary buffers to add objects to instead of using the correct
ones. I think this was debug code. This commit removes that code in
favor of writing to the actual buffers.

Closes #17846.

Co-authored-by: Alice Cecile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Actually add objects to the scene buffers in sorted render phases. pcwalton/bevy
3 participants
@pcwalton @rparrett @ickshonpe