Skip to content

Local CI (cargo r -p ci) fails because it seems to run docs in stable but uses attributes of nightly: #16871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alice-i-cecile opened this issue Dec 17, 2024 · 3 comments · Fixed by #16891
Closed

Local CI (cargo r -p ci) fails because it seems to run docs in stable but uses attributes of nightly: #16871

alice-i-cecile opened this issue Dec 17, 2024 · 3 comments · Fixed by #16891
Labels
A-Build-System Related to build systems or continuous integration C-Docs An addition or correction to our documentation S-Needs-Design This issue requires design work to think about how it would best be accomplished

Comments

@alice-i-cecile
Copy link
Member 

          Note that local CI (`cargo r -p ci`) still fails because it seems to run docs in stable but uses attributes of nightly:

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> src\lib.rs:2:21
  |
2 | #![cfg_attr(docsrs, feature(doc_auto_cfg))]
  |

Originally posted by @djeedai in #16862 (comment)
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Build-System Related to build systems or continuous integration S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! labels Dec 17, 2024
@BenjaminBrienen BenjaminBrienen added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Dec 18, 2024
@mockersf
Copy link
Member

caused by #16147, as I warned

@alice-i-cecile alice-i-cecile added S-Needs-Design This issue requires design work to think about how it would best be accomplished and removed S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Dec 18, 2024
@alice-i-cecile
Copy link
Member Author

#15387 is the ultimate cause of our nightly docs requirements; let me look into this.

@mockersf
Copy link
Member

mockersf commented Dec 18, 2024 •
edited
Loading

all nightly needs are behind a cfg, #16147 enabled that cfg when checking docs. it should enable it only when a nightly is detected

@alice-i-cecile alice-i-cecile mentioned this issue Dec 18, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 19, 2024
@alice-i-cecile
Revert "Make doc CI use nightly (#16147)" (#16891)
05c6931 
This reverts commit 58a7392.

# Objective

This is causing local `cargo run -p ci` runs to fail on `stable` Rust
when used locally. Fixes #16871.

## Solution

Revert #16147. We shouldn't have merged this until we had a full
solution (I missed a Controversial tag, sorry!).

## Testing

`cargo run -p ci` fails for me before this change in the reported
fashion. After this reversion, it passes.
ecoskey pushed a commit to ecoskey/bevy that referenced this issue Jan 6, 2025
@alice-i-cecile @ecoskey
Revert "Make doc CI use nightly (bevyengine#16147)" (bevyengine#16891)
4368670 
This reverts commit 58a7392.

# Objective

This is causing local `cargo run -p ci` runs to fail on `stable` Rust
when used locally. Fixes bevyengine#16871.

## Solution

Revert bevyengine#16147. We shouldn't have merged this until we had a full
solution (I missed a Controversial tag, sorry!).

## Testing

`cargo run -p ci` fails for me before this change in the reported
fashion. After this reversion, it passes.
mrchantey pushed a commit to mrchantey/bevy that referenced this issue Feb 4, 2025
@alice-i-cecile @mrchantey
Revert "Make doc CI use nightly (bevyengine#16147)" (bevyengine#16891)
c08f871 
This reverts commit 58a7392.

# Objective

This is causing local `cargo run -p ci` runs to fail on `stable` Rust
when used locally. Fixes bevyengine#16871.

## Solution

Revert bevyengine#16147. We shouldn't have merged this until we had a full
solution (I missed a Controversial tag, sorry!).

## Testing

`cargo run -p ci` fails for me before this change in the reported
fashion. After this reversion, it passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Docs An addition or correction to our documentation S-Needs-Design This issue requires design work to think about how it would best be accomplished
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Make doc CI use nightly (#16147)" alice-i-cecile/bevy
3 participants
@alice-i-cecile @mockersf @BenjaminBrienen