Skip to content

Move all_tuples and friends into its own crate #15941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bushrat011899 opened this issue Oct 16, 2024 · 8 comments · Fixed by #16161
Closed

Move all_tuples and friends into its own crate #15941

bushrat011899 opened this issue Oct 16, 2024 · 8 comments · Fixed by #16161
Assignees
@BenjaminBrienen
Labels
A-Utils Utility functions and types D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Milestone
0.16

Comments

@bushrat011899
Copy link
Contributor

bushrat011899 commented Oct 16, 2024 •
edited
Loading

FYI I'm merging the simple fix in #15933 now, but I do think we should move fully to this. It does make me think we should pull all_tuples out into its own crate though: I'm not a fan of bevy_math relying on bevy_utils.

Originally posted by @alice-i-cecile in #15936 (comment)
@bushrat011899 bushrat011899 added S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! A-Utils Utility functions and types D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Oct 16, 2024
@bushrat011899 bushrat011899 added this to the 0.16 milestone Oct 16, 2024
@alice-i-cecile
Copy link
Member

This should be part of the Bevy extended universe, over with atomiccow. The name of the crate should not have "Bevy" in it to encourage broader adoption.

@bushrat011899
Copy link
Contributor Author

To commence the bikeshedding, I propose polytuple as a name.

@alice-i-cecile
Copy link
Member

variadics_please gets my vote.

@bushrat011899
Copy link
Contributor Author

Oh in line with the not-BSN crate, i-cant-believe-its-not-variadics

@MrGVSV
Copy link
Member

MrGVSV commented Oct 16, 2024

I like variadics_please, but maybe we should also consider keeping the name all_tuples (assuming someone else hasn't taken it)? Especially considering it's a fairly known about macro in the community.

@alice-i-cecile
Copy link
Member

I think that putting variadics into the crate name in some form is helpful for searchability. I also think it's a natural home for any other variadic-related functionality that Bevy or other users might need.

@bushrat011899
Copy link
Contributor Author

Since bevy_utils/macros only contains all_tuples! and all_tuples_with_size!, it seems like the steps are pretty straightforward:

  1. Reserve the name variadics_please on crates.io
  2. Create the repository bevyengine/variadics_please
  3. Copy bevy_utils/macros into the new repo, polish the documentation, etc.
  4. Publish
  5. Update bevy_utils to re-export variadics_please, or update the other crates to directly use variadics_please instead.

@BenjaminBrienen
Copy link
Contributor

https://crates.io/crates/variadics_please

@BenjaminBrienen BenjaminBrienen mentioned this issue Oct 29, 2024
Merged
@BenjaminBrienen BenjaminBrienen self-assigned this Oct 29, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 3, 2024
@BenjaminBrienen
Move all_tuples to a new crate (#16161)
afd0f13 
# Objective

Fixes #15941

## Solution

Created https://crates.io/crates/variadics_please and moved the code
there; updating references

`bevy_utils/macros` is deleted.

## Testing

cargo check

## Migration Guide

Use `variadics_please::{all_tuples, all_tuples_with_size}` instead of
`bevy::utils::{all_tuples, all_tuples_with_size}`.
ecoskey pushed a commit to ecoskey/bevy that referenced this issue Jan 6, 2025
@BenjaminBrienen @ecoskey
Move all_tuples to a new crate (bevyengine#16161)
0cac0de 
# Objective

Fixes bevyengine#15941

## Solution

Created https://crates.io/crates/variadics_please and moved the code
there; updating references

`bevy_utils/macros` is deleted.

## Testing

cargo check

## Migration Guide

Use `variadics_please::{all_tuples, all_tuples_with_size}` instead of
`bevy::utils::{all_tuples, all_tuples_with_size}`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenjaminBrienen BenjaminBrienen

Labels
A-Utils Utility functions and types D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
0.16
Development

Successfully merging a pull request may close this issue.

Move all_tuples to a new crate BenjaminBrienen/bevy
4 participants
@bushrat011899 @alice-i-cecile @BenjaminBrienen @MrGVSV