Skip to content

render_primitives example panics when changing cameras #15822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rparrett opened this issue Oct 10, 2024 · 0 comments · Fixed by #15946
Closed

render_primitives example panics when changing cameras #15822

rparrett opened this issue Oct 10, 2024 · 0 comments · Fixed by #15946
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Milestone
0.15

Comments

@rparrett
Copy link
Contributor

Bevy version

main, since #15320

Relevant system information

SystemInfo { os: "MacOS 14.5 ", kernel: "23.5.0", cpu: "Apple M1 Max", core_count: "10", memory: "64.0 GiB" }
AdapterInfo { name: "Apple M1 Max", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }

Also tested win+4080

What you did

  • cargo run --example render_primitives
  • Press c twice

What went wrong

2024-10-10T13:51:35.072520Z  WARN bevy_render::camera::camera: Camera order ambiguities detected for active cameras with the following priorities: {(0, Some(Window(NormalizedWindowRef(0v1#4294967296))))}. To fix this, ensure there is exactly one Camera entity spawned with a given order for a given RenderTarget. Ambiguities should be resolved because either (1) multiple active cameras were spawned accidentally, which will result in rendering multiple instances of the scene or (2) for cases where multiple active cameras is intentional, ambiguities could result in unpredictable render results.
thread 'Compute Task Pool (2)' panicked at crates/bevy_core_pipeline/src/core_3d/mod.rs:663:22:
The depth texture usage should already exist for this target
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Encountered a panic in system `bevy_core_pipeline::core_3d::prepare_core_3d_depth_textures`!

Additional information

Related to #15570, broken out here because there are specific repro steps to document.
@rparrett rparrett added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Oct 10, 2024
@alice-i-cecile alice-i-cecile added this to the 0.15 milestone Oct 10, 2024
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Oct 10, 2024
rafalh added a commit to rafalh/bevy that referenced this issue Oct 16, 2024
@rafalh
Fix deactivated camera still being used in render world
cfd614c 
Switch to retained render world causes the extracted cameras in render
world to not be removed until camera in main world is despawned.
When extracting data from main world inactive cameras are skipped.
Therefore camera that was active and became inactive has a retained
`ExtractedCamera` component from previous frames (when it was active) and
is processed the same way as if it were active (there is no `active` field
on `ExtractedCamera`). This breakes switching between cameras in
`render_primitives` example.

Fix it by removing `ExtractedCamera` and related components from inactive
cameras.
Note that despawning inactive camera seems to be bad option because
they are spawned using `SyncToRenderWorld` component.

Fixes bevyengine#15822
@rafalh rafalh mentioned this issue Oct 16, 2024
Merged
rafalh added a commit to rafalh/bevy that referenced this issue Oct 16, 2024
@rafalh
Fix deactivated camera still being used in render world
86be404 
Switch to retained render world causes the extracted cameras in render
world to not be removed until camera in main world is despawned.
When extracting data from main world inactive cameras are skipped.
Therefore camera that was active and became inactive has a retained
`ExtractedCamera` component from previous frames (when it was active) and
is processed the same way as if it were active (there is no `active` field
on `ExtractedCamera`). This breakes switching between cameras in
`render_primitives` example.

Fix it by removing `ExtractedCamera` and related components from inactive
cameras.
Note that despawning inactive camera seems to be bad option because
they are spawned using `SyncToRenderWorld` component.

Fixes bevyengine#15822
@rafalh rafalh mentioned this issue Oct 16, 2024
Closed
13 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 19, 2024
@rafalh @akimakinai
Fix deactivated camera still being used in render world (#15946)
fe7f98f 
# Objective

Switch to retained render world causes the extracted cameras in render
world to not be removed until camera in main world is despawned. When
extracting data from main world inactive cameras are skipped. Therefore
camera that was active and became inactive has a retained
`ExtractedCamera` component from previous frames (when it was active)
and is processed the same way as if it were active (there is no `active`
field on `ExtractedCamera`). This breakes switching between cameras in
`render_primitives` example.
Fixes #15822

## Solution

Fix it by removing `ExtractedCamera` and related components from
inactive cameras.
Note that despawning inactive camera seems to be bad option because they
are spawned using `SyncToRenderWorld` component.

## Testing

Switching camera in `render_primitives` example now works correctly.

---------

Co-authored-by: akimakinai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

Fix deactivated camera still being used in render world rafalh/bevy
2 participants
@rparrett @alice-i-cecile