Skip to content

Consider not allocating in the empty archetype on world.spawn() #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alice-i-cecile opened this issue Mar 5, 2021 · 1 comment
Closed

Consider not allocating in the empty archetype on world.spawn() #1556

alice-i-cecile opened this issue Mar 5, 2021 · 1 comment
Labels
A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times S-Needs-Investigation This issue requires detective work to figure out what's going wrong

Comments

@alice-i-cecile
Copy link
Member

  • ex: return something like EntityMutUninit, which turns into EntityMut after an insert or insert_bundle op
  • this actually regressed performance last time i tried it, but in theory it should be faster

From Future Work of #1525.
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times labels Mar 5, 2021
@alice-i-cecile alice-i-cecile added S-Needs-Design This issue requires design work to think about how it would best be accomplished S-Needs-Investigation This issue requires detective work to figure out what's going wrong and removed S-Needs-Design This issue requires design work to think about how it would best be accomplished labels Dec 12, 2021
@james7132
Copy link
Member

Is this still relevant after #6054? Seems like we're now avoiding this empty Archetype allocation on any non-trivial spawn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times S-Needs-Investigation This issue requires detective work to figure out what's going wrong
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@james7132 @alice-i-cecile