Skip to content

Commit f124314

Browse files
MrGVSVtim-blackbird
andcommitted
Direct collect boxed slices
Co-authored-by: ira <[email protected]>
1 parent df0c42b commit f124314

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

crates/bevy_reflect/src/enums/enum_trait.rs

+2-5
Original file line numberDiff line numberDiff line change
@@ -157,17 +157,14 @@ impl EnumInfo {
157157
.map(|(index, variant)| (variant.name(), index))
158158
.collect::<HashMap<_, _>>();
159159

160-
let variant_names = variants
161-
.iter()
162-
.map(|variant| variant.name())
163-
.collect::<Vec<_>>();
160+
let variant_names = variants.iter().map(|variant| variant.name()).collect();
164161

165162
Self {
166163
name,
167164
type_name: std::any::type_name::<TEnum>(),
168165
type_id: TypeId::of::<TEnum>(),
169166
variants: variants.to_vec().into_boxed_slice(),
170-
variant_names: variant_names.into_boxed_slice(),
167+
variant_names,
171168
variant_indices,
172169
#[cfg(feature = "documentation")]
173170
docs: None,

crates/bevy_reflect/src/enums/variants.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,11 @@ impl StructVariantInfo {
9999
/// Create a new [`StructVariantInfo`].
100100
pub fn new(name: &'static str, fields: &[NamedField]) -> Self {
101101
let field_indices = Self::collect_field_indices(fields);
102-
let field_names = fields.iter().map(|field| field.name()).collect::<Vec<_>>();
102+
let field_names = fields.iter().map(|field| field.name()).collect();
103103
Self {
104104
name,
105105
fields: fields.to_vec().into_boxed_slice(),
106-
field_names: field_names.into_boxed_slice(),
106+
field_names,
107107
field_indices,
108108
#[cfg(feature = "documentation")]
109109
docs: None,

crates/bevy_reflect/src/struct_trait.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -94,14 +94,14 @@ impl StructInfo {
9494
.map(|(index, field)| (field.name(), index))
9595
.collect::<HashMap<_, _>>();
9696

97-
let field_names = fields.iter().map(|field| field.name()).collect::<Vec<_>>();
97+
let field_names = fields.iter().map(|field| field.name()).collect();
9898

9999
Self {
100100
name,
101101
type_name: std::any::type_name::<T>(),
102102
type_id: TypeId::of::<T>(),
103103
fields: fields.to_vec().into_boxed_slice(),
104-
field_names: field_names.into_boxed_slice(),
104+
field_names,
105105
field_indices,
106106
#[cfg(feature = "documentation")]
107107
docs: None,

0 commit comments

Comments
 (0)